New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulator: standardize queue messages #32313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
github-actions
bot
added
simulation
running openpilot in environments like CARLA
tools
labels
Apr 28, 2024
bongbui321
changed the title
Simulator; standardize queue messages
Simulator: standardize queue messages
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prereq for: #32308.
This PR make it so that there is only one queue created from
./run_bridge.py
, which will be used for reading termination reason for CIBefore, the message put into the queue in the Simulator were of type
dict
with different number of fields, andstr
. This PR standardize the message put into the queue to be of typenamedtuple
namedQueueMessage
.There will be 4 types of
QueueMessage
start_status
: "starting" and "started"control_command
: IO control commands (up, down, left, right)termination_info
: reason for terminationclose_status
: closing status