Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulator: standardize queue messages #32313

Merged
merged 15 commits into from May 18, 2024

Conversation

bongbui321
Copy link
Contributor

@bongbui321 bongbui321 commented Apr 28, 2024

prereq for: #32308.

This PR make it so that there is only one queue created from ./run_bridge.py, which will be used for reading termination reason for CI

Before, the message put into the queue in the Simulator were of type dict with different number of fields, and str. This PR standardize the message put into the queue to be of type namedtuple named QueueMessage.

There will be 4 types of QueueMessage
start_status: "starting" and "started"
control_command: IO control commands (up, down, left, right)
termination_info: reason for termination
close_status: closing status

Copy link
Contributor

github-actions bot commented Apr 28, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added simulation running openpilot in environments like CARLA tools labels Apr 28, 2024
@bongbui321 bongbui321 changed the title Simulator; standardize queue messages Simulator: standardize queue messages Apr 28, 2024
@bongbui321 bongbui321 marked this pull request as draft April 28, 2024 22:13
@bongbui321 bongbui321 marked this pull request as ready for review April 28, 2024 22:32
@adeebshihadeh adeebshihadeh merged commit 630e152 into commaai:master May 18, 2024
28 checks passed
@bongbui321 bongbui321 deleted the queue_message branch May 19, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simulation running openpilot in environments like CARLA tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants