Skip to content

Commit

Permalink
Honda: fix missing interceptor tests (#886)
Browse files Browse the repository at this point in the history
* setUpClass never did anything

* oh, comments work as pass?

* pass

* Update tests/safety/test_honda.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
  • Loading branch information
sshane and adeebshihadeh committed Mar 22, 2022
1 parent 991638a commit 0591f68
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
3 changes: 0 additions & 3 deletions tests/safety/common.py
Expand Up @@ -60,9 +60,6 @@ def setUpClass(cls):
cls.safety = None
raise unittest.SkipTest

# make sure interceptor is detected
cls._rx(cls._interceptor_msg(0, 0x201)) # pylint: disable=no-value-for-parameter

@abc.abstractmethod
def _interceptor_msg(self, gas, addr):
pass
Expand Down
4 changes: 0 additions & 4 deletions tests/safety/test_honda.py
Expand Up @@ -379,9 +379,6 @@ class TestHondaNidecInterceptorSafety(TestHondaNidecSafety, common.InterceptorSa
"""
Covers the Honda Nidec safety mode with a gas interceptor
"""
def setUp(self):
TestHondaNidecSafety.setUpClass()
common.InterceptorSafetyTest.setUpClass()


class TestHondaNidecAltSafety(TestHondaNidecSafety):
Expand Down Expand Up @@ -414,7 +411,6 @@ def setUp(self):
self.safety = libpandasafety_py.libpandasafety
self.safety.set_safety_hooks(Panda.SAFETY_HONDA_NIDEC, Panda.FLAG_HONDA_NIDEC_ALT)
self.safety.init_tests_honda()
common.InterceptorSafetyTest.setUpClass()

def _acc_state_msg(self, main_on):
values = {"MAIN_ON": main_on, "COUNTER": self.cnt_acc_state % 4}
Expand Down

0 comments on commit 0591f68

Please sign in to comment.