Honda: fix missing interceptor tests #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
commented
Mar 22, 2022
| @@ -60,9 +60,6 @@ def setUpClass(cls): | |||
| cls.safety = None | |||
| raise unittest.SkipTest | |||
|
|
|||
| # make sure interceptor is detected | |||
| cls._rx(cls._interceptor_msg(0, 0x201)) # pylint: disable=no-value-for-parameter | |||
There was a problem hiding this comment.
This never ran with the Toyota tests, and all interceptor tests call this at the start anyway
sshane
commented
Mar 22, 2022
| @@ -379,9 +379,7 @@ class TestHondaNidecInterceptorSafety(TestHondaNidecSafety, common.InterceptorSa | |||
| """ | |||
| Covers the Honda Nidec safety mode with a gas interceptor | |||
| """ | |||
| def setUp(self): | |||
| TestHondaNidecSafety.setUpClass() | |||
| common.InterceptorSafetyTest.setUpClass() | |||
There was a problem hiding this comment.
This and below caused these tests to skip
sshane
changed the title
sshane
commented
Mar 22, 2022
tests/safety/test_honda.py
Outdated
| @@ -379,6 +379,7 @@ class TestHondaNidecInterceptorSafety(TestHondaNidecSafety, common.InterceptorSa | |||
| """ | |||
| Covers the Honda Nidec safety mode with a gas interceptor | |||
| """ | |||
| pass | |||
There was a problem hiding this comment.
Fails static analysis...
budney
added a commit
to budney/panda
that referenced
this pull request
Mar 27, 2022
e01c645 Toyota: increase torque rate limit (commaai#887) 0591f68 Honda: fix missing interceptor tests (commaai#886) 991638a Tesla: only allow cancel button (commaai#880)
budney
pushed a commit
to budney/panda
that referenced
this pull request
Mar 28, 2022
From: budney 2650024 Renamed unsafe_mode to alternative_experience in subaru-community code. From: commaai/master Merge: 0e79ab3^..7104818 7104818 rename unsafeMode to alternativeExperience (commaai#878) e01c645 Toyota: increase torque rate limit (commaai#887) 0591f68 Honda: fix missing interceptor tests (commaai#886) 991638a Tesla: only allow cancel button (commaai#880) 499906f Nissan + Tesla: don't exit controls allowed on blocked message (commaai#877) ba10911 GM: enters controls on falling edge of button presses (commaai#876) 868fd53 Hyundai: enter controls on falling edge of buttons (commaai#875) 4acaebb Honda: enter controls on falling edge of button presses (commaai#874) e6722c7 Honda Nidec: match openpilot engagement behavior (commaai#872) a53528a Add more hints when troubleshooting panda (commaai#864) 5a7af82 Hyundai: only allow cancel while cruise is enabled (commaai#870) 891653f Docker: bump openpilot and fix Toyota EPS scale factor for test (commaai#869) 234e436 rename to enable_deepsleep 860e5a4 Red Panda: auto switching to CAN FD with BRS (commaai#868) 4f422ed C2: fix bootkick (commaai#854) de7e1e7 Deep sleep(stop) mode for pandas (commaai#832) e8e9d84 fix release script 51ccb9f HITL tests: change testing speeds (commaai#862) 8435bda CAN FD: adjust bit timing settings to SAE specifications J2284-4 and J2284-5 (commaai#861) cb88a17 Honda: revert back to button enable for Nidec (commaai#858) 2806eec python: add safety param arg to set_safety_mode 9d27011 misc CAN FD fixes (commaai#856) 0e79ab3 Fix USB enumeration detection for C2 (commaai#853)
budney
pushed a commit
to budney/panda
that referenced
this pull request
Jun 8, 2022
* setUpClass never did anything * oh, comments work as pass? * pass * Update tests/safety/test_honda.py Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calling
common.InterceptorSafetyTest.setUpClass()from a Honda test, however itssetUpClasschecks if the class name is itself and if so, then skip the test. However, when calling from a childcls.__name__was always the parent, so it just skipped those tests.