Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iso-tp: revert CAN frame length check #1411

Merged
merged 1 commit into from
May 13, 2023
Merged

Conversation

sshane
Copy link
Contributor

@sshane sshane commented May 13, 2023

Reverts #1315

The iso-tp spec allows optimization of the data field only with certain frame types. So while we know of no cases where this is a problem, we should revert until we handle properly

10.4.2.2	 CAN frame data optimization (TX_DL = 8)
If this solution is used, the DLC does not always need to be 8. If the N_PDU to be transmitted is shorter
than 8 bytes, then the sender may optimize the CAN bus load by shortening the CAN frame data to
contain only the number of bytes occupied by the N_PDU (no padding of unused data bytes). CAN frame
data optimization can only be used for an SF, FC frame or the last CF of a segmented message.

@sshane sshane marked this pull request as ready for review May 13, 2023 05:09
@sshane sshane changed the title iso-tp: revert CAN frame length assertion iso-tp: revert CAN frame length check May 13, 2023
@sshane sshane merged commit 675b1e8 into master May 13, 2023
@sshane sshane deleted the revert-isotp-len-check branch May 13, 2023 05:14
Edison-CBS pushed a commit to Edison-CBS/panda that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant