Use --help after command and argument #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
commented
Mar 14, 2020
orien
commented
Mar 14, 2020
| # Supports multi-word commands, using the largest possible match. | ||
|
|
||
| private def longest_valid_command_name_from(args) | ||
| valid_command_names_from(*args.dup).max |
There was a problem hiding this comment.
Extract a new method to keep things DRY.
I've made a small optimisation change here. I predict max will be faster than stort.last as it'll get the same result without creating a new Array.
- valid_command_names_from(*args.dup).sort.last
+ valid_command_names_from(*args.dup).max
ggilder
requested changes
Mar 15, 2020
ggilder
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It is reported in #94 that using
--helpafter a command name and command argument does not work.Investigation finds the
helpcommand is assuming the the command name is all the arguments joined together.commander/lib/commander/runner.rb
Line 307 in b8abd42
Change
Fix #94 by changing the line in question to ignore the command argument when searching for command name. Just take the longest valid command name found in the arguments.
Considerations
This also changes the behaviour of the help command in its alternate form. This will ignore the argument and provide the documentation for the specified command, where previously it would give an error message.