Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize VerbAttribute #473

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Localize VerbAttribute #473

merged 1 commit into from
Jul 16, 2019

Conversation

moh-hassan
Copy link
Collaborator

This PR is extending PR #356 to localize VerbAttribute

@moh-hassan
Copy link
Collaborator Author

@gkelling
You can try the new dev package that include the localization of PR #356 and VerbAttributes.
I appreciate your feedback before merging the PR.

@gkelling
Copy link

gkelling commented Jul 12, 2019

@moh-hassan
I pulled down the package and re-tested that I can use resx to localize the Options help text and tested to localizing the Verb help text, both of these were successful.

I also verified that instead of using the provided example in the previous PR
[Option("lastname", HelpText = "LastName", ResourceType = typeof(EmployeeResx))]

You can use this as well
[Option("lastname", HelpText = nameof(EmployeeResx.LastName), ResourceType = typeof(EmployeeResx))]

@moh-hassan
Copy link
Collaborator Author

Thanks @gkelling for feedback. I'll merge this PR.

@moh-hassan moh-hassan merged commit 86d7582 into commandlineparser:develop Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants