Critical enddate comparison operator fix #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's still broken. Your local master is not up to date (git checkout master && git pull origin master) |
This fix makes sure enddates themselves are included in a tax period.
el-seirh
force-pushed
the
critical-enddate-comparison-operator-fix
branch
from
890e149
to
de046dc
Compare
|
I'm gonna close this one again since I have been able to correctly sync my forks master but failed to correctly rewind my PR branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue in the TaxRate models getAmount-function. When matching the date against the end dates the > operator was used instead of >=.
This led to a behaviour where any date that exactly matched any periods end date would not return a tax rate.