-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update remark monorepo (major) #693
Conversation
🦋 Changeset detectedLatest commit: 2c81526 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/commercetools/commercetools-docs-kit/fp5utsnk4 |
This requires some investigation around the usage of the commercetools-docs-kit/packages/gatsby-theme-docs/src/utils/markdown-fragment-to-react.js Line 39 in 24a0f4b
syntax-tree/mdast-util-to-hast@142e973 cc @nkuehn |
488255c
to
b8eaeef
Compare
@emmenko good catch thanks! remark-react 8 is using an alpha of remark 13, so we'll have to wait here. ( https://github.com/remarkjs/remark-react/blob/8.0.0/package.json#L54 ) remark 13 switches to micromark, which again defaults to commonmark, so we'll maybe have to wait until remark 13 is released and we can upgrade everything remark related at once. |
b8eaeef
to
f80e571
Compare
f80e571
to
87e7326
Compare
This PR should be good to go if you switch to the alpha of remark-parse, |
@wooorm thanks for the hint. We'll try that! |
@wooorm using version Do we need to change/configure something in that regards? Thanks |
Please see the aforementioned issue, it mentions that you now need remark-gfm for gfm |
Thanks again, I missed that point. |
Looks wonderful! |
@nkuehn should we put this on hold, are you comfortable shipping this? We can also wait that the stable |
(lost my whole explanation by closing the browser - so here's a short form only) TL;DR: We actually don't want tables in this fragment renderer, which is intended for MD snippets rendered inside lists, table cells and other smaller data driven compartments. The whole fuss with overriding the table rendering with a bullet list was just here because the current code seems to have silently do GFM (or parts of it) without having to explicitly ask it. Autolinks are even actively discouraged in documentation, you want choice over whether a string that looks like a URL is a link or not.
|
to add about remark: a) it’s table, I’ll publish it tomorrow as is, b) gfm is no longer on by default, but in remark-gfm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pre-approve" for when the new remark is released stable. Thanks for your help @wooorm !
18e9fed
to
2c81526
Compare
This PR contains the following updates:
2.0.0
->3.0.0
7.0.1
->8.0.0
Release Notes
remarkjs/remark-frontmatter
v3.0.0
Compare Source
fb1357b
Update formicromark
inremark@13
(breaking, this update will not work for remark lower than v13)
remarkjs/remark-react
v8.0.0
Compare Source
f1c83f9
Update dependencies(breaking, potentially, see commit for details)
Renovate configuration
📅 Schedule: "before 3am on Monday" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by WhiteSource Renovate. View repository job log here.