Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on clock? #3

Closed
snoyberg opened this issue Dec 31, 2017 · 3 comments
Closed

Depend on clock? #3

snoyberg opened this issue Dec 31, 2017 · 3 comments

Comments

@snoyberg
Copy link
Collaborator

We can probably provide some very useful helpful functions, like logTimed. We already do stuff like this in Stack for running external processes, and can generalize it.

@chrisdone
Copy link
Member

The clock package apparently has weird bugs. I think we could copy/paste the timing code from Criterion which works reliably: https://hackage.haskell.org/package/criterion-1.2.6.0/docs/Criterion-Measurement.html

In favor of including logTimed (assuming something like MonadLogger m => m a -> m a is what you're talking about).

snoyberg referenced this issue in fpco/unliftio Jan 7, 2018
See snoyberg/codename-karka#3
@snoyberg
Copy link
Collaborator Author

snoyberg commented Jan 7, 2018

See fpco/unliftio#15

snoyberg referenced this issue in fpco/unliftio Jan 7, 2018
See snoyberg/codename-karka#3
snoyberg added a commit that referenced this issue Jan 7, 2018
snoyberg referenced this issue in fpco/unliftio Jan 7, 2018
See snoyberg/codename-karka#3
@snoyberg
Copy link
Collaborator Author

snoyberg commented Jan 7, 2018

getMonotonicTime added to unliftio, closing.

@snoyberg snoyberg closed this as completed Jan 7, 2018
@akhra akhra mentioned this issue Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants