Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reexports with lifted versions of functions #55

Closed
snoyberg opened this issue Mar 6, 2018 · 4 comments
Closed

Replace reexports with lifted versions of functions #55

snoyberg opened this issue Mar 6, 2018 · 4 comments

Comments

@snoyberg
Copy link
Collaborator

snoyberg commented Mar 6, 2018

Functions specialized to IO should be generalized to either MonadIO or MonadUnliftIO. Applies at least to the modules RIO.ByteString, RIO.Directory, and RIO.ByteString.Lazy. Pointed out by @adituv in #53.
roman added a commit to roman/rio that referenced this issue Mar 9, 2018
@roman
Lift stdlib functions from LByteString and System.Directory (closes c…
0ef56f9 
…ommercialhaskell#55)
roman added a commit to roman/rio that referenced this issue Mar 9, 2018
@roman
Allow Directory to work on lts-7 (closes commercialhaskell#55)
f36ef5a
roman added a commit to roman/rio that referenced this issue Mar 9, 2018
@roman
Use qualified imports for RIO.Directory (closes commercialhaskell#55)
86e6a74
@adituv
Copy link
Collaborator

adituv commented Mar 9, 2018

I have a few more functions here and there to add to the list: adituv/rio@1005404...adituv:55-lift-reexports

Happy to submit as a separate PR after #58 goes through, or equally happy for @roman to add them to that PR.

snoyberg added a commit that referenced this issue Mar 10, 2018
@snoyberg
Merge pull request #58 from roman/ISSUE-55-lift-stdlib-functions
95da03d 
Lift functions from Lazy.ByteString and System.Directory (closes #55)
@snoyberg
Copy link
Collaborator Author

Thanks to you both! I'm going to reopen this, there are still a number of functions that need lifted versions.

@snoyberg snoyberg reopened this Mar 10, 2018
@adituv
Copy link
Collaborator

adituv commented Mar 10, 2018

Could you list some of the functions that need lifted versions? That is, if you aren't planning to just fix them yourself.

@snoyberg
Copy link
Collaborator Author

I'd forgotten that I'd already added lifted versions for RIO.ByteString! Alright, scratch that, I'm not aware of others. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snoyberg @adituv