Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Data.Sequence to RIO structure modules? #57

Closed
roman opened this issue Mar 9, 2018 · 3 comments
Closed

Include Data.Sequence to RIO structure modules? #57

roman opened this issue Mar 9, 2018 · 3 comments

Comments

@roman
Copy link
Contributor

roman commented Mar 9, 2018

Hello,

Wondering why there is no RIO export for Data.Sequence, is there a reason why is this the case?
@snoyberg
Copy link
Collaborator

snoyberg commented Mar 9, 2018

I can't think of a reason to exclude it, I'd be in favor of a PR to add it.

@roman
Copy link
Contributor Author

roman commented Mar 9, 2018

I've always wondered why the module name was Sequence and the data structure was Seq, what do you think about naming the module RIO.Seq instead of RIO.Sequence?

roman added a commit to roman/rio that referenced this issue Mar 9, 2018
@roman
Add RIO.Seq module (closes commercialhaskell#57)
689745b
snoyberg added a commit that referenced this issue Mar 10, 2018
@snoyberg
Merge pull request #59 from roman/ISSUE-57-rio-seq
89ce70e 
Add RIO.Seq module (closes #57)
@snoyberg
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roman @snoyberg