Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepseq-generics 0.2.0.0 #1096

Closed
DanBurton opened this issue Jan 3, 2016 · 15 comments
Closed

deepseq-generics 0.2.0.0 #1096

DanBurton opened this issue Jan 3, 2016 · 15 comments

Comments

@DanBurton
Copy link
Contributor

deepseq-generics-0.2.0.0 depended on by:

  • pandoc-1.16 (==0.1.*). No maintainer. @jgm
  • pandoc-types-1.16 (==0.1.*). No maintainer. @jgm
@DanBurton
Copy link
Contributor Author

If this issue is resolved, it may become blocked by #1094.

@jgm
Copy link
Contributor

jgm commented Jan 6, 2016

OK, I've released pandoc-types-1.16.0.1, which should
help with this. (It still depends on deepseq-generics
for ghc < 7.10, but for ghc 7.10 it just uses deepseq.)

+++ Dan Burton [Jan 03 16 10:30 ]:

deepseq-generics-0.2.0.0 depended on by:
* pandoc-1.16 (==0.1.). No maintainer. [1]@jgm
* pandoc-types-1.16 (==0.1.
). No maintainer. [2]@jgm


Reply to this email directly or [3]view it on GitHub.

References

  1. https://github.com/jgm
  2. https://github.com/jgm
  3. deepseq-generics 0.2.0.0 #1096

@peti
Copy link
Contributor

peti commented Jan 8, 2016

I thought that deepseq-generics is obsolete with modern versions of GHC? deepseq versions 1.4.x or later have that functionality builtin.

@peti
Copy link
Contributor

peti commented Jan 8, 2016

According to http://hackage.haskell.org/package/deepseq-1.4.1.2/docs/Control-DeepSeq.html#v:rnf:

Starting with GHC 7.2, you can automatically derive instances for types possessing a Generic instance.

{-# LANGUAGE DeriveGeneric #-}

import GHC.Generics (Generic)
import Control.DeepSeq

data Foo a = Foo a String
             deriving (Eq, Generic)

instance NFData a => NFData (Foo a)

data Colour = Red | Green | Blue
              deriving Generic

instance NFData Colour

@jgm
Copy link
Contributor

jgm commented Jan 8, 2016

+++ Peter Simons [Jan 08 16 09:29 ]:

I thought that deepseq-generics is obsolete with modern versions of
GHC? deepseq versions 1.4.x or later have that functionality builtin.

Yes, pandoc-types uses deepseq 1.4.x when we can, and deepseq-generics for older GHCs.

@bergmark
Copy link
Member

@jgm pandoc still depends on deepseq-generics unconditionally.

This is also blocked by #1094

@jgm
Copy link
Contributor

jgm commented Jan 11, 2016

+++ Adam Bergmark [Jan 11 16 02:46 ]:

[1]@jgm pandoc still depends on deepseq-generics unconditionally.

No it doesn't (pandoc-types-1.16.0.1) -- it's conditional on the
ghc version:

if impl(ghc < 7.10)
   Build-depends:   deepseq-generics >= 0.1 && < 0.2
 else
   Build-depends:   deepseq >= 1.4.1 && < 1.5

@bergmark
Copy link
Member

@jgm
Copy link
Contributor

jgm commented Jan 11, 2016

+++ Adam Bergmark [Jan 11 16 12:01 ]:

[1]https://github.com/jgm/pandoc/blob/master/pandoc.cabal#L279

Ah, sorry...I wasn't even aware it was used there.

@bergmark
Copy link
Member

Thanks! This is resolved but pandoc is still held back by (edit: typo) #1094 so I'll track it there.

@jgm
Copy link
Contributor

jgm commented Jan 12, 2016

Note, I haven't actually released a new version yet, but
I can probably do that in the next week or so.

+++ Adam Bergmark [Jan 11 16 16:08 ]:

Thanks! This is resolved but pandoc is still held back by [1]#1096 so
I'll track it there.


Reply to this email directly or [2]view it on GitHub.

References

  1. deepseq-generics 0.2.0.0 #1096
  2. deepseq-generics 0.2.0.0 #1096 (comment)

@bergmark
Copy link
Member

Sorry, my bad this time. I thought I checked hackage...

@DanBurton
Copy link
Contributor Author

I've reopened this issue to properly track the following.

deepseq-generics-0.2.0.0 depended on by:

Is there any compelling reason to push for deepseq-generics-0.2 in lts-5, or are we fine with 0.1?

@acfoltzer
Copy link
Contributor

AFAIK the main change with 0.2 is GHC 8 compatibility, so if lts-5 is targeting 7.10.3, there's probably limited benefit

@snoyberg
Copy link
Contributor

Issue closed in the GHC 8 release. If packages have been removed temporarily, please sent a pull request to update build-constraints.yaml (search for GHC 8 or BLOCKED).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants