Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-types 0.11 test failures #3226

Closed
DanBurton opened this issue Jan 25, 2018 · 3 comments
Closed

http-types 0.11 test failures #3226

DanBurton opened this issue Jan 25, 2018 · 3 comments

Comments

@DanBurton
Copy link
Contributor

As noted in the changelog for http-types

  • 0.11 [2017-11-29]
    Remove dependency on blaze-builder. (Note that as a side effect of this, URI encoding is now using lower-case rather than uppercase hexadecimal.)

A number of test suites are now failing, apparently because they expect URI encoding to produce uppercase hexadecimal when it now produces lowercase.

  • Spock-core
  • amazonka-ec2
  • amazonka-s3
  • amazonka-sqs
  • ginger

I'm going to check with the maintainers of these projects to see what they think about the issue and whether we should proceed with http-types 0.11.

@DanBurton
Copy link
Contributor Author

Issues filed with:

The person who filed the issue with amazonka noted that the URI spec says:

For consistency, URI producers and
normalizers should use uppercase hexadecimal digits for all percent-
encodings.

It is my opinion, for this reason, that we should not accept http-types 0.11 into Stackage.

I have opened an issue on http-types asking the maintainer to go back to uppercasing URI encodings. aristidb/http-types#83

@DanBurton
Copy link
Contributor Author

We are anticipating a release of http-types 0.12, which will address this issue.

@aristidb
Copy link

http-types 0.12 is released now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants