Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versions and npm support #69

Closed
chrisflatley opened this issue Dec 11, 2020 · 1 comment
Closed

Versions and npm support #69

chrisflatley opened this issue Dec 11, 2020 · 1 comment

Comments

@chrisflatley
Copy link
Contributor

React & React Dom should be allow | 17.0.0. types for react and react-dom are not 17.0.0. THis will align with material ui (currently template wants 17, but this components doesnt).

React script is now 4.0.1, but looks like 4.0.2 will be support TS 4.1 (then we can bump both to the latest versions).

Tthis is through npm install on template, it won't let me complete at the moment though next issues with be storybook etc).
stuarthendren added a commit that referenced this issue Dec 15, 2020
@stuarthendren
Adds react 17 as valid peer dependency
cc1ddda 
see #69
@chrisflatley
Copy link
Contributor Author

Closing - I believe this work has been done (at least appears to work on current projects).

npm/TS/CRA/etc versions are more stable now (2021) so the ecosystem seems to have caught up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisflatley