Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip 'update-cli-screenshots' if no changes #1139

Merged
merged 1 commit into from
May 23, 2024
Merged

ci: skip 'update-cli-screenshots' if no changes #1139

merged 1 commit into from
May 23, 2024

Conversation

marcosdotme
Copy link
Contributor

@marcosdotme marcosdotme commented May 22, 2024

Description

Job update-cli-screenshots was failling when no changes detected on docs/images/cli_help and blocking other jobs to run.

Closes: #1138

Checklist

  • Add test cases to all the changes you introduce (not applicable)
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes (not applicable)

Expected behavior

Job update-cli-screenshots must be skipped if no changes detected on docs/images/cli_help

Screenshots

Overview

image

Explanation

I made two commits:

  1. Commit with no changes related to CLI, so theres no changes detected from update-cli-screenshots (114383c).
  2. Commit with changes on CLI (changed description of commands) (b585baf).

Note that commit with no changes exits with status 0 and don't creates the commit "docs(cli/screenshots): update CLI screenshots"

More screenshots

Workflow run for commit with no changes

image

Workflow run for commit with changes

image

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (120d514) to head (608368c).
Report is 345 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
+ Coverage   97.33%   97.54%   +0.20%     
==========================================
  Files          42       55      +13     
  Lines        2104     2486     +382     
==========================================
+ Hits         2048     2425     +377     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.54% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosdotme marcosdotme marked this pull request as ready for review May 22, 2024 14:06
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. But we'll have to change the commit message type to ci instead of fix.

@marcosdotme marcosdotme changed the title fix: skip 'update-cli-screenshots' if no changes ci: skip 'update-cli-screenshots' if no changes May 23, 2024
@marcosdotme
Copy link
Contributor Author

The code looks good. But we'll have to change the commit message type to ci instead of fix.

Done!

@Lee-W Lee-W merged commit 8f88d56 into commitizen-tools:master May 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip "git push" is no screenshot is updated in job "update-cli-screenshots"
2 participants