Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ignore fixup! & squash! #551

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

a5r0n
Copy link
Contributor

@a5r0n a5r0n commented Aug 8, 2022

Description

#414

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #551 (ca35a55) into master (ed636ba) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
+ Coverage   98.26%   98.32%   +0.05%     
==========================================
  Files          39       39              
  Lines        1556     1551       -5     
==========================================
- Hits         1529     1525       -4     
+ Misses         27       26       -1     
Flag Coverage Δ
unittests 98.32% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/commands/check.py 100.00% <ø> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/cmd.py 100.00% <100.00%> (ø)
commitizen/git.py 100.00% <100.00%> (ø)
commitizen/changelog.py 100.00% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@bhelgs
Copy link
Contributor

bhelgs commented Aug 10, 2022

Disclaimer: I am not a maintainer.

I wonder what happens to the changelog if you forget to rebase these out of existence. Is it (correctly) ignoring them?

@a5r0n
Copy link
Contributor Author

a5r0n commented Aug 12, 2022

the validate_commit_message called only when u run cz check (like the pre-commit do).
so i think the changelog be not impacted.

@a5r0n a5r0n marked this pull request as ready for review August 12, 2022 10:42
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a5r0n Thanks for contribution! I'm good with it. @woile could you please check whether you're good with it. Thanks!

@eldipa
Copy link

eldipa commented Aug 16, 2022

Could be possible to load the prefixes to ignore from the config file? I'm thinking that Merge, Revert, fixup! are quite standard but they may not fit in any project and a simple solution could load the prefixes from a file (leaving the current prefixes Merge, Revert and so on as default).

What do you think?

@Lee-W
Copy link
Member

Lee-W commented Aug 20, 2022

Hi @eldipa , I think that's a good idea! But I wish to keep this PR as it is. We could create another issue / PR for tracking the feature you mention. Thanks!

@Lee-W
Copy link
Member

Lee-W commented Sep 19, 2022

@woile I'm thinking of merging this one this week. Please let me know if we need more discussion on this one :)

@Lee-W Lee-W merged commit d0df263 into commitizen-tools:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants