-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ignore fixup! & squash! #551
Conversation
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
==========================================
+ Coverage 98.26% 98.32% +0.05%
==========================================
Files 39 39
Lines 1556 1551 -5
==========================================
- Hits 1529 1525 -4
+ Misses 27 26 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Disclaimer: I am not a maintainer. I wonder what happens to the changelog if you forget to rebase these out of existence. Is it (correctly) ignoring them? |
the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be possible to load the prefixes to ignore from the config file? I'm thinking that What do you think? |
Hi @eldipa , I think that's a good idea! But I wish to keep this PR as it is. We could create another issue / PR for tracking the feature you mention. Thanks! |
@woile I'm thinking of merging this one this week. Please let me know if we need more discussion on this one :) |
Description
#414
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context