-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump changelog for prerelease without commits #681
fix: bump changelog for prerelease without commits #681
Conversation
5bdd714
to
b328f6a
Compare
LGTM, could you also update the complexity to 13? Thank you so much 🎉 |
2e39d78
to
32258ff
Compare
@woile done, thanks! |
Could you please rebase? Thanks! |
32258ff
to
89122d0
Compare
generate changelog for a new version without new commits when the current version is a prerelease. This matches current behaviour for bump command
89122d0
to
ca725f2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
=======================================
Coverage 97.42% 97.43%
=======================================
Files 42 42
Lines 2022 2027 +5
=======================================
+ Hits 1970 1975 +5
Misses 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@woile rebased ✅ |
@woile any chance we can merge and release this soon, please? |
Description
This changes lets the changelog be generated for version bumps from a prerelease version without new commits, which the
bump
command already allows.Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
User should be able to bump a prerelease version and generate a changelog for the new version without adding new commits
Steps to Test This Pull Request
bump
command:cz bump --changelog --prerelease alpha
bump
command without adding new commits:cz bump --changelog [--prerelease beta]
Current behavior:
Fails when attempting to generate the changelog with
--changelog
flag$ cz bump --changelog --prerelease alpha --yes bump: release 0.37.0 → 0.38.0a0 Automatically generated by Commitizen. tag to create: v0.38.0a0 increment detected: MINOR [main 013cdd0] bump: release 0.37.0 → 0.38.0a0 4 files changed, 9 insertions(+), 3 deletions(-) Done! $ cz bump --changelog --prerelease rc --yes bump: release 0.38.0a0 → 0.38.0rc0 Automatically generated by Commitizen. tag to create: v0.38.0rc0 No commits found
Expected behavior:
Should bump version and generate changelog with empty change list
Additional context