-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add select_all miniwdl Stdlib function #161
Conversation
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 90.61% 90.88% +0.26%
==========================================
Files 3 3
Lines 618 625 +7
Branches 180 183 +3
==========================================
+ Hits 560 568 +8
Misses 25 25
+ Partials 33 32 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
select_all
is typically paired with if
or scatter
in WDL, so it might be a bit soon to implement this.
Can you make your branch on the main repo? It makes it simpler to collaborate :-)
Maybe consider using https://github.com/griffithlab/analysis-wdls/blob/25cf2010055d79bf7df63ab832363066eba87a26/definitions/subworkflows/merge_svs.wdll as an example? There select_all
on a source selector for a workflow step could be represented in CWL by using pickValue: all_non_null
@kinow I ran your CWL code, but it always returns empty arrays for me. I had to make the following adjustment outputEval: $([inputs.one, inputs.two, 1, [inputs.two, inputs.one].find(function(element)
{ return element !== null }) ].filter(function(element) { return element !== null })
) |
For later, happy if anyone (@mr-c ? 😬 ) takes over 👍 |
b28f7bd
to
6b223b0
Compare
Also implement the round() function
No description provided.