Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance sort order conformance test to test for consistent ordering, but not a specific locale #233

Open
Tracked by #54
mr-c opened this issue May 17, 2017 · 5 comments
Assignees
Milestone

Comments

@mr-c
Copy link
Member

mr-c commented May 17, 2017

Or just to the (unwritten) implementation guidance doc?

https://twitter.com/biocrusoe/status/864700272722944001

@mr-c
Copy link
Member Author

mr-c commented Jan 9, 2018

At today's meeting we have come to the conclusion that we should default to C for now

@mr-c mr-c changed the title Do we need to add a default locale to the spec? enhance sort order conformance test to test for consistent locale, but not a specific locale Jan 16, 2018
@mr-c
Copy link
Member Author

mr-c commented Jan 16, 2018

new plan:

  1. No more default locale.
  2. Duplicate https://github.com/common-workflow-language/common-workflow-language/blob/master/v1.0/v1.0/glob_test.cwl with a different "wrong" order
  3. Add step to compare of glob_test.cwl and glob_test2.cwl, fail if not matching
  4. Document in v1.1 v1.2.1 that glob sort orders must be consistent.

@mr-c
Copy link
Member Author

mr-c commented Jan 19, 2018

Also confirm that when an array of patterns is passed to glob that each result is sorted, but not all together. Thanks to @milos-ljubinkovic for finding this!

@tom-tan
Copy link
Member

tom-tan commented Nov 27, 2018

Hi.

The reason why I opened common-workflow-language/common-workflow-language#801 is that the behavior of glob with array is not documented and that the actual behavior in cwltool (that passes both of 121 and 172) seems to be inconsistent for me.
If the behavior is documented in the spec, it is OK for me.

@mr-c mr-c changed the title enhance sort order conformance test to test for consistent locale, but not a specific locale enhance sort order conformance test to test for consistent ordering, but not a specific locale Jan 24, 2019
@mr-c mr-c assigned tetron and unassigned mr-c Apr 17, 2023
@mr-c mr-c transferred this issue from common-workflow-language/common-workflow-language Apr 17, 2023
@mr-c mr-c added this to the 1.2.1 milestone Apr 17, 2023
@mr-c
Copy link
Member Author

mr-c commented Apr 17, 2023

@tetron @mvdbeek @GlassOfWhiskey and I affirmed the plan in #233 (comment) today

@GlassOfWhiskey reminded us that cwltest might need an upgrade to ignore the order of arrays..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants