model - discriminated unions with parent properties #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply parent properties first, so children can overwrite the discriminator with their Literal value
commonism
force-pushed
the
discriminated_union_merging
branch
from
1457319
to
6959248
Compare
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 94.38% 94.47% +0.08%
==========================================
Files 83 83
Lines 6180 6187 +7
==========================================
+ Hits 5833 5845 +12
+ Misses 347 342 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply parent properties first, so children can overwrite the discriminator with their Literal value