Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with Stripe #14

Closed
wants to merge 1 commit into from
Closed

Conversation

conatus
Copy link
Member

@conatus conatus commented May 4, 2023

Description

Motivation and Context

How Can It Be Tested?

How Will This Be Deployed?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I've checked the spec (e.g. Figma file) and documented any divergences.
  • My code follows the code style of this project.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I've updated the documentation accordingly.
  • Replace unused checkboxes with bullet points.

@conatus conatus changed the title Update readme.md Make it work with Stripe May 4, 2023
@conatus
Copy link
Member Author

conatus commented May 4, 2023

  1. Replace all this stuff - https://github.com/commonknowledge/join/blob/master/packages/join-block/lib/services/join_service.php#L19-L266 with the Stripe equivalent.
  2. Add any corresponding code needed on the front end join flow, remembering the Monorail app does this - https://github.com/commonknowledge/ckmap/tree/main/ckmap
  3. Clean up any files that are lying around that reference the old stuff, like the GoCardless service and so on.
  4. Remove any dependencies that are about GoCardless or ChargeBee.
  5. Done!

@conatus
Copy link
Member Author

conatus commented May 4, 2023

Wiring in the React code to Monorail:

Probably don't need these levels of modularity here, but the component for interracting with Stripe looks like it could be copied into this code.

@conatus conatus closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant