Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sentry to record job performance metrics #54

Merged
merged 21 commits into from
Jun 6, 2024
Merged

Conversation

joaquimds
Copy link

Logs job performance metrics to sentry using sentry_sdk.set_measurement

Description

Records:

  • time job waiting
  • job execution time
  • update rows requested
  • import rows requested

Motivation and Context

https://linear.app/commonknowledge/issue/MAP-32/updateimport-job-metrics

How Can It Be Tested?

Import / Update a few times and check the metrics on Sentry are updated.
TODO: Where are these?

How Will This Be Deployed?

Normal method.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I've checked the spec (e.g. Figma file) and documented any divergences.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I've updated the documentation accordingly.
  • Replace unused checkboxes with bullet points.

@janbaykara
Copy link
Member

janbaykara commented May 31, 2024

LGTM @joaquimds but haven't tested.

@joaquimds joaquimds merged commit 3ada163 into main Jun 6, 2024
2 of 3 checks passed
@joaquimds joaquimds deleted the feat/sentry-metrics branch June 6, 2024 15:23
Copy link

sentry-io bot commented Jun 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: import_all() got an unexpected keyword argument 'requested_at' hub.tasks in wrapper View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants