forked from mysociety/local-intelligence-hub
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Sentry to record job performance metrics #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an for sending to sentry
… job - log to console for now
…and remove un-needed fields
joaquimds
force-pushed
the
feat/sentry-metrics
branch
from
May 23, 2024 16:00
519e068
to
35fbc2a
Compare
LGTM @joaquimds but haven't tested. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs job performance metrics to sentry using
sentry_sdk.set_measurement
Description
Records:
Motivation and Context
https://linear.app/commonknowledge/issue/MAP-32/updateimport-job-metrics
How Can It Be Tested?
Import / Update a few times and check the metrics on Sentry are updated.
TODO: Where are these?
How Will This Be Deployed?
Normal method.
Screenshots (if appropriate):
Types of changes
Checklist: