Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests and CI config #1

Merged
merged 12 commits into from
Jul 24, 2020
Merged

Add unit tests and CI config #1

merged 12 commits into from
Jul 24, 2020

Conversation

ryukinix
Copy link
Member

@ryukinix ryukinix commented Jul 24, 2020 •
edited
Loading

CHANGELOG:

  • Refactor project to make easier to mocking-up on tests
  • Simplify main function using smaller functions
  • Improves code test coverage of the project with automated tests
  • Clairify godoc of some functions
  • Add new github action test: lint, test and coverage

@ryukinix
Improve function godocs
f1478b0
@ryukinix
Add troll_shield_test.go with simple test for getUserName
015f763 
The other functions is just too hard to mocking properly. I need
to refactor it later to make easier to test.

Currently, the most critical function that needs test it is
findTrollHouses.
@ryukinix ryukinix requested a review from luksamuk July 24, 2020 13:09
@ryukinix ryukinix self-assigned this Jul 24, 2020
@ryukinix
Copy link
Member Author

ryukinix commented Jul 24, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2c092c2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   60.00%           
=========================================
  Files             ?        1           
  Lines             ?      110           
  Branches          ?        0           
=========================================
  Hits              ?       66           
  Misses            ?       44           
  Partials          ?        0
Flag Coverage Δ
#unittests 60.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c092c2...c5056f0. Read the comment docs.

@ryukinix
Copy link
Member Author

ALELUIA!

@ryukinix ryukinix requested review from parjanya and removed request for luksamuk July 24, 2020 19:11
@ryukinix ryukinix added the enhancement New feature or request label Jul 24, 2020
@ryukinix ryukinix merged commit 8b116f5 into master Jul 24, 2020
@ryukinix ryukinix deleted the feature/tests branch July 24, 2020 20:57
@ryukinix ryukinix mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parjanya parjanya Awaiting requested review from parjanya

Assignees

@ryukinix ryukinix

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryukinix