Add support to qualified command like /pass@lelerax_bot #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I finally registered the bot commands via API, so we have autocomplete on Telegram by using the bot. In groups using /pass or /kills would be translated to /pass@lelerax_bot and /kills@lelerax_bot, but in v0.7.0 troll-shield version this is not supported. This PR takes care to support this properly, giving attention to edge cases like using /pass@anotherBotName (this will not work). /pass /kill simplified syntax will always works, but can trigger multiple bots if they implements the same command. CHANGELOG: - Add checkCommand which checks properly if is a valid command - Add commandEvent which can be use to filter commands (performance) - Add unit tests for both functions - Rename /lelerax to /ping, which makes more sense. - Add renan_r as admin.
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 94.15% 94.44% +0.29%
==========================================
Files 1 1
Lines 171 180 +9
==========================================
+ Hits 161 170 +9
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally registered the bot commands via API, so we have autocomplete
on Telegram by using the bot. In groups using /pass or /kills would be
translated to /pass@lelerax_bot and /kills@lelerax_bot, but in v0.7.0
troll-shield version this is not supported.
This PR takes care to support this properly, giving attention to edge
cases like using /pass@anotherBotName (this will not work). /pass
/kill simplified syntax will always works, but can trigger multiple
bots if they implements the same command.
CHANGELOG: