Feature: troll shield anti ban system #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important because if the targer trollHouse banned this bot, it
will fail to find troll with this error:
{
"description": "Forbidden: bot was kicked from the supergroup chat",
"error_code": 403,
"ok": false
}
However, if we use a hidden bot (unknown from trolls) to only make
this request, it works pretty fine. After all, they never will know
which bot to ban to stop the troll-shield.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
===========================================
+ Coverage 60.00% 78.98% +18.98%
===========================================
Files 1 1
Lines 110 138 +28
===========================================
+ Hits 66 109 +43
+ Misses 44 29 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Although this works as expected, this MR do not have yet proper unit tests. For that reason, I'll not merge a ready and I'll launch only a release-candidate version. |
ryukinix
force-pushed
the
feature/troll-shield-anti-ban-system
branch
from
5c9972b
to
a1d451e
Compare
mateusfccp
reviewed
Jul 28, 2020
| } | ||
|
|
||
| func leaveChat(bot TrollShieldBot, update *telegram.Update, trollGroup string) { | ||
| reply(bot, update, "Nesse grupo há trolls. Dou-me a liberdade de ir embora. Adeus.") |
There was a problem hiding this comment.
I like this message. Nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add secondary bot setup to only make findTrollHouses request
This is important because if the target trollHouse banned this bot, it
will fail to find troll with this error:
However, if we use a hidden bot (unknown from trolls) to only make
this request, it works pretty fine. After all, they never will know
which bot to ban to stop the troll-shield.
This feature is optional and it's enabled automatically when the env var
TELEGRAM_BOT_HIDDEN_TOKENis available.Add leaveChat events when troll-shield is on trollGroups
Now the bot will leaves the chat when happens this events: