Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /pass command #6

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Add /pass command #6

merged 2 commits into from
Aug 10, 2020

Conversation

ryukinix
Copy link
Member

CHANGELOG:

  • Add /pass command
  • It only works when called from commonlispbr admins (currently hardcoded, I can change it later)
  • Learned: There is no built-in remove function for slices in golang

@ryukinix ryukinix requested a review from luksamuk August 10, 2020 12:52
@ryukinix
Copy link
Member Author

Codecov Report

Merging #6 into master will decrease coverage by 16.60%.
The diff coverage is 3.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
- Coverage   93.52%   76.92%   -16.61%     
===========================================
  Files           1        1               
  Lines         139      169       +30     
===========================================
  Hits          130      130               
- Misses          9       39       +30     
Flag Coverage Δ
#unittests 76.92% <3.22%> (-16.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
troll_shield.go 76.92% <3.22%> (-16.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b8e84...fa0bd2f. Read the comment docs.

Copy link
Member

@luksamuk luksamuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateusfccp mateusfccp merged commit 9c6e781 into master Aug 10, 2020
@mateusfccp mateusfccp deleted the feature/passlist branch August 10, 2020 13:14
@ryukinix
Copy link
Member Author

The unit tests was not written before the PR was merged. That should be addressed in the next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants