Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master #734

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

master #734

wants to merge 2 commits into from

Conversation

snan
Copy link

@snan snan commented Mar 27, 2023

  • Allow implementers to emit i and b
  • Address the Gomphocarpus example

@snan
Allow implementers to emit i and b
6a254f5 
Issue commonmark#652.
@snan
Address the Gomphocarpus example
6e5bcdb 
This example was not a correct use of strong or of em.
(It's a good showcase for why strong and em are wrong.)

Changed it to b and i, which the new rule 13 from the previous commit
now allows.

I'm putting this in a separate commit since another solution would be
to change it to foo and bar.
@snan snan mentioned this pull request Mar 28, 2023
Open
@rlidwka
Copy link
Contributor

rlidwka commented May 10, 2023 •
edited
Loading

These examples are not just examples, they are test cases, which every single parser runs to verify spec conformance.

So after this commit spec now mandates the use of different tags for the *(**foo**)* and **Gomphocarpus (*Gomphocarpus physocarpus*, syn. *Asclepias physocarpa*)**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snan @rlidwka