-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTKDICOMCore linker error #25
Comments
Hi, as a quick fix: yes. Under Unix-like systems DCMTK detects which third party libraries are available during compilation, namely LIB...ZLIB, PNG, TIFF, XML and OPENSSL. If those libs are detected and used (linked) into the object files in DCMTK, then they must also be linked in CTK. The best way would be to "export" the libraries found during DCMTK build to CTK build where appropriate. I am not sure what is the right way to do this in CMake. If the feature connected to those 3rd party libs (DCMTK runs fine without them) are not needed anyway, one could specify this in DCMTK.cmake as -DDCMTK_WITH_TIFF:BOOL=OFF. These are the features you loose (from what I remember by heart): OpenSSL: DICOM signatures and TLS-secured communication (rarely used both in DICOM) I would say it would make most sense to disable the third party libraries for now if it is not very simple to add to the CTK linker flags. |
Okay, manually setting DCMTK_WITH_ZLIB to OFF works, CTKDICOMCore does From what I know from other toolkits, you (DCMTK) would either support set(DCMTK_USE_ZLIB 1) # or 0 For a "quick fix", I would agree to set DCMTK_WITH_ZLIB to off, since we On 08/02/2011 01:54 PM, trabs wrote:
|
+1 for DCMTK_USE_FILE, until that happens, let's turn off DCMTK_WITH_ZLIB. |
Alright ;) I will take care of it tomorrow and disable all 3rd party libs as a quick fix. Next days I will look for a better solution. |
Ahm, okay. I just disabled zlib, all other defaults work out of the box on Ubuntu 11.04 for now. |
The thing is that others might encounter the same problems with the other libs, so it is more safe to disable them all per default. |
Okay, you are right. Looking at the CMakeLists.txt file of DCMTK, the DCMTK_WITH_TIFF Correct? I also think a first simple version of a DCMTKConfig.cmake file Thanks, On 08/02/2011 10:50 PM, trabs wrote:
|
Hi, I disabled all 3rd party libs for now. Your list above is correct, however, I also disabled OpenSSL since it costs a line and nobody has to do research why OpenSSL is not explicitly turned off. I will look into a DCMTKConfig.cmake next days. Also the FindDCMTK script is not optimal, however, I am not sure about the best way to deal with different DCMTK versions, i.e. there are older versions with less libraries inside DCMTK (like oflog, dcmjpls). Thanks for reporting and solving issue :) |
Great, thanks! On 08/03/2011 10:35 AM, trabs wrote:
|
Are there any updates on this issue? Is it still dependent on DCMTKConfig.cmake? |
Guys, by disabling zlib you lose support of the deflated transfer syntax. No better solution, huh? |
At the CTK level it's probably easiest to leave all of these off. But it's also possible for applications that use CTK to point to their own DCMTK build that can have these turned on (for example, Slicer builds both dcmtk and zlib so it could put them together before passing down to CTK). |
Since we can act upon all the pieces, zlib, dcmtk ... supporting this should be possible. |
On my Ubuntu 11.04 machine, libCTKDICOMCore does not link due to missing zlib symbols.
Adding "z" to the link libraries of CTKDCIOMCore would solve this issue. Is this the way to go?
The text was updated successfully, but these errors were encountered: