ENH: Allow instantiation of more CTK objects in Python #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTK objects that only had default constructor (no Object* parameter) were not possible to instantiate in Python: >>> a=ctk.ctkErrorLogLevel() Traceback (most recent call last): File "<console>", line 1, in <module> ValueError: No constructors available for ctkErrorLogLevel The issue is fixed by passing arguments of the superclass constructor.
jcfr
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CTK objects that only had default constructor (no Object* parameter) were not possible to instantiate in Python:
The issue is fixed by passing arguments of the superclass constructor.
This pull request (along with #985) supersedes #796. Accepting arguments in the constructor (that are passed on to the superclass constructor) is a better solution than accepting wrapping of constructors that don't take any arguments.