BUG: Fix python wrapping for classes with only default constructor #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hina-shah
force-pushed
the
fix-python-wrapping
branch
from
5139140
to
3dbf59b
Compare
|
👍 This looks good to me, but let's hold off until @jcfr is back to look at it. |
|
@jcfr : When you get time, could you please look at this PR? Thanks! CircleCi failed on uploading the report at the end, but other than that all the tests were passed. |
|
Thanks Hina. Travelling , I will have a look when I am back in office
around May 7.
Thanks
Jc
…On Mon, Apr 23, 2018, 7:34 AM hina-shah ***@***.***> wrote:
@jcfr <https://github.com/jcfr> : When you get time, could you please
look at this PR? Thanks! CircleCi failed on uploading the report at the
end, but other than that all the tests were passed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#796 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANXo61JY8SsWg_OP9ErpWpQshhgBlxhks5treZ5gaJpZM4TQvUN>
.
|
|
Hi @jcfr, could you take a look at this again? Thanks! |
|
@jcfr Please have a look at it whenever you have time. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
Fixes regular expression in
ctkWrapPythonQt.pywhich parses the class constructors to populate the classes to be passed to PythonQT for wrapping. It was skipping the classes which only had default constructors (i.e. no constructors of the typeclassName(QObject* ...). Also, the closing parenthesis was not identified. @jcfr: you might want to check the RE! I have compared the build outputs (by switching on verbose in thectkMacroWrapPythonQt.cmake), and the following classes are added to Python wrapping now:ctkErrorLogLevel,ctkErrorLogQtMessageHandler,ctkErrorLogTerminalOutput, andctkEventTranslatorPlayerWidget.ctkErrorLogAbstractMessageHandleris skipped because it has a pure virtual method, and not because the constructor type is wrong. The other classes are unaffected.Adds a default constructor to
ctkCheckableHeaderViewclass so that it will be included for Python wrapping. This is actually a hack. Some methods of the class are enabled for Python wrapping as well.