-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ordering of options, flags and subcommands #227
Conversation
Codecov ReportBase: 83.71% // Head: 82.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 83.71% 82.89% -0.83%
==========================================
Files 21 21
Lines 1584 1584
==========================================
- Hits 1326 1313 -13
- Misses 258 271 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I think the main concern of having an extra dependency on OrderedCollections initially was the loading time impact which can be critical for use cases like CLI tools. But this PR seems OK on 1.8 (maybe due to compiler improvements) julia> @time using Comonicon #master
0.085131 seconds (278.01 k allocations: 20.346 MiB)
julia> @time using Comonicon # this PR
0.084021 seconds (278.05 k allocations: 20.348 MiB) |
@@ -9,6 +9,7 @@ ExproniconLite = "55351af7-c7e9-48d6-89ff-24e801d99491" | |||
Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb" | |||
Logging = "56ddb016-857b-54e1-b83d-db4d58db5568" | |||
Markdown = "d6f4376e-aef5-505a-96c1-9c027394607a" | |||
OrderedCollections = "bac558e1-5e72-5ebc-8fee-abe8a469f55d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add a compat field for OrderedCollections in this file too
Co-authored-by: Rogerluo <hiroger@qq.com>
@Roger-luo , thanks for the comments! I made the changes, and they're ready for a review :) |
|
Yeah, my bad, that's what I meant. Instead of saying that |
This PR fixes #226 . It additionally sorts all subcommands alphabetically. Tests for ordering are also there.
Code to test by hands: