Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simspi import #38

Closed
wants to merge 5 commits into from
Closed

Conversation

geoffwoollard
Copy link
Contributor

Trying to sort out import errors in #25

@geoffwoollard geoffwoollard added the bug Something isn't working label Jan 27, 2022
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #38 (d56953e) into master (684e90c) will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   94.49%   94.81%   +0.33%     
==========================================
  Files           5        5              
  Lines         308      308              
==========================================
+ Hits          291      292       +1     
+ Misses         17       16       -1     
Impacted Files Coverage Δ
ioSPI/fourier.py 100.00% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684e90c...d56953e. Read the comment docs.

@geoffwoollard
Copy link
Contributor Author

Passing all tests branching off main.

@geoffwoollard
Copy link
Contributor Author

geoffwoollard commented Jan 27, 2022

@arjunsingh3600 I can import simSPI

@ninamiolane
Copy link
Contributor

The test function import... does not start with test_: did you check that pytest is able to find it and run it? Sometimes, the test runners only run functions that start with test_.

@ninamiolane
Copy link
Contributor

@geoffwoollard did this get resolve or should we close?

@geoffwoollard geoffwoollard marked this pull request as draft February 15, 2022 18:24
@geoffwoollard
Copy link
Contributor Author

I will close since this PR should have been draft. It was just to point out that there was no issue importing simSPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants