Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve pytorch3d dependency issue - platform dependence #45

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

harshit-gupta-cor
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #45 (8ded88f) into master (91cc053) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files           8        8           
  Lines         285      285           
=======================================
  Hits          277      277           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91cc053...8ded88f. Read the comment docs.

@fredericpoitevin
Copy link
Member

@harshit-gupta-cor I don't think this is the right fix. We need to have install instructions separate for Mac and Linux as detailed here: https://github.com/facebookresearch/pytorch3d/blob/main/INSTALL.md#installing-prebuilt-binaries-for-pytorch3d

@fredericpoitevin fredericpoitevin changed the title added pytorch3d as conda and pip dependency solve pytorch3d dependency issue - platform dependence Dec 15, 2021
@ninamiolane
Copy link
Contributor

@harshit-gupta-cor @fredericpoitevin what is the update on this? is this the right fix or not?

@harshit-gupta-cor
Copy link
Contributor Author

@harshit-gupta-cor @fredericpoitevin what is the update on this? is this the right fix or not?

Sorry my bad for not updating this. The commit was done so that the environment works for both mac and linux by having pytorch3d installation from both conda (for linux) and pip (for mac). However, we decided that we will keep only linux version.

Therefore, I will just remove pytorch3d from pip. I will commit that ASAP. Since I have mac, I will first check if the changed environment is installable on sdf cluster and then will commit.

@ninamiolane
Copy link
Contributor

@harshit-gupta-cor fantastic, thanks!

@harshit-gupta-cor
Copy link
Contributor Author

@ninamiolane Changes done. This can be merged now.

Copy link
Contributor

@ninamiolane ninamiolane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @harshit-gupta-cor !!

@ninamiolane ninamiolane merged commit 1b47249 into compSPI:master Jan 21, 2022
@harshit-gupta-cor harshit-gupta-cor deleted the environment_linux_mac branch January 28, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants