-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solve pytorch3d dependency issue - platform dependence #45
solve pytorch3d dependency issue - platform dependence #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=======================================
Coverage 97.20% 97.20%
=======================================
Files 8 8
Lines 285 285
=======================================
Hits 277 277
Misses 8 8 Continue to review full report at Codecov.
|
@harshit-gupta-cor I don't think this is the right fix. We need to have install instructions separate for Mac and Linux as detailed here: https://github.com/facebookresearch/pytorch3d/blob/main/INSTALL.md#installing-prebuilt-binaries-for-pytorch3d |
@harshit-gupta-cor @fredericpoitevin what is the update on this? is this the right fix or not? |
Sorry my bad for not updating this. The commit was done so that the environment works for both mac and linux by having pytorch3d installation from both conda (for linux) and pip (for mac). However, we decided that we will keep only linux version. Therefore, I will just remove pytorch3d from pip. I will commit that ASAP. Since I have mac, I will first check if the changed environment is installable on sdf cluster and then will commit. |
@harshit-gupta-cor fantastic, thanks! |
@ninamiolane Changes done. This can be merged now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @harshit-gupta-cor !!
No description provided.