Run fprettify on rwfnestimate #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed -i -E 's/^\s+(SUBROUTINE|PROGRAM|MODULE)/\1/' *.f90
|
Let's discuss this as well when we meet next week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, instead of manually undoing all the unnecessary whitespace changes in #28, we can avoid these types of issues altogether in the future by relying on automation and have fprettify format the code automatically. This is sort of a test run -- trying out applying the standard fprettify rules on
rwnfestimate, before ideally running it on the whole of GRASP.For #28, if we merge this, we can run
fprettifyon that branch there and then we should only have non-trivial changes show up in the diff.There was one small hurdle -- it looks like fprettify will keep whatever initial indentation the first line of code has for the whole file (e.g. if the
PROGRAMstatement has 6 spaces in front of it, then fprettify will put 6 spaces in front of every line; would need fortran-lang/fprettify#53). To work around that, I usedsed -i -E 's/^\s+(SUBROUTINE|PROGRAM|MODULE)/\1/' *.f90to remove all whitespace from those lines before running fprettify.