Remove xcpp kernelspec #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 52.42% 52.42%
=======================================
Files 15 15
Lines 599 599
=======================================
Hits 314 314
Misses 285 285 |
mcbarton
force-pushed
the
remove-xcpp-spec
branch
3 times, most recently
from
bebc0f5
to
86ea1ea
Compare
|
@JohanMabille @vgvassilev This PR is ready for review |
JohanMabille
approved these changes
May 13, 2024
|
@vgvassilev can you merge this PR now it has been approved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remove the xcpp kernelspec, since its now redundant.
Fixes #89