Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom IoSlice #94

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Add custom IoSlice #94

merged 6 commits into from
Oct 13, 2023

Conversation

George-Miao
Copy link
Member

@George-Miao George-Miao commented Oct 12, 2023 •
edited
Loading

This PR adds IoSlice and IoSliceMut to compio-buf to provide a more flexible api compare to the std one.

@George-Miao George-Miao self-assigned this Oct 12, 2023
@George-Miao George-Miao added the enhancement New feature or request label Oct 12, 2023
@George-Miao George-Miao mentioned this pull request Oct 12, 2023
Closed
@George-Miao George-Miao marked this pull request as ready for review October 12, 2023 23:13
@George-Miao George-Miao removed the request for review from bdbai October 13, 2023 00:28
Berrysoft
Berrysoft approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Berrysoft Berrysoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao George-Miao merged commit fca9d22 into compio-rs:master Oct 13, 2023
11 checks passed
@George-Miao George-Miao deleted the feat/io_slice branch October 13, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berrysoft Berrysoft Berrysoft approved these changes

Assignees

@George-Miao George-Miao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@George-Miao @Berrysoft