Feature/participant deletion #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prob needs to be moved elsewhere and used as a shared def. duplicated code for now
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
inc datatable, basic delete functionality
includes refactor of activate protocol procedure
lastUploadedProtocol is stale and needs fix
ported over from feature/participant deletion
removed but needed for interview/new route
Merged
more consistent with participants dashboard
mrkarimoff
reviewed
Oct 17, 2023
app/(dashboard)/dashboard/_components/ParticipantsTable/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
mrkarimoff
suggested changes
Oct 17, 2023
…is refactor simplifies code in all instances of this component. parent components now just control opening the dialog and passing it the selected participants. the dialog itself handles calculating derived properties, deleting, and cancelling. this makes this logic reusable across instances and removes duplicated code
actionsdropdown manages dialog state, deleteprotocolsdialog manages actual deletion, calculating derived props, cancelling dialog
allows actionsdropdown and addparticipantbutton to use the same modal, but with separate instances and separately controlling state
jthrilly
requested changes
Oct 26, 2023
app/(dashboard)/dashboard/_components/ParticipantsTable/ParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
pass actionsdropdown and optional header as simple props. let datatable handle passing row and data to the actionsdropdowns
jthrilly
approved these changes
Oct 27, 2023
| @@ -28,7 +29,8 @@ interface DataTableProps<TData, TValue> { | |||
| data: TData[]; | |||
| filterColumnAccessorKey?: string; | |||
| handleDeleteSelected?: (data: TData[]) => Promise<void> | void; | |||
| actions?: ColumnDef<TData, TValue>[]; | |||
| actions?: React.ComponentType<{ row: Row<TData>; data: TData[] }>; | |||
There was a problem hiding this comment.
Nice! Didn't know this is how you did it. This is super cool, because it also validates the data type being passed to the table!
| }, | ||
| }, | ||
| ]} | ||
| actions={ActionsDropdown} |
There was a problem hiding this comment.
The component API for data table is looking great now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
UI:
Deleting participants which have no interview data:
Deleting participants with exported interview data:
Deleting participants with un-exported interview data
