Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/onboarding upload participants #27

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

buckhalt
Copy link
Member

Updates onboarding process to use new upload participants/csv processing code

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fresco ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 2:38pm

fixes issue where importcsvmodal toasts were not showing up on onboarding
Copy link
Contributor

@mrkarimoff mrkarimoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. I don't see anything that needs to be changed 👍

Copy link
Member

@jthrilly jthrilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be going crazy here, but wasn't this feature supposed to be about using the new upload protocol functionality? Doesn't this just add CSV upload?

app/(onboard)/layout.tsx Outdated Show resolved Hide resolved
@buckhalt buckhalt changed the title Feature/onboarding upload protocol Feature/onboarding upload participants Oct 23, 2023
@buckhalt
Copy link
Member Author

I might be going crazy here, but wasn't this feature supposed to be about using the new upload protocol functionality? Doesn't this just add CSV upload?

Sorry, I have no idea why I named this PR incorrectly. Fixed the name now. This is supposed to be https://app.clickup.com/t/8685ynge0, adding the csv participants upload.

@jthrilly jthrilly merged commit 1eefbc3 into main Oct 23, 2023
3 checks passed
@jthrilly jthrilly deleted the feature/onboarding-upload-participants branch April 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants