Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/error boundaries #28

Merged
merged 15 commits into from
Oct 31, 2023
Merged

Feature/error boundaries #28

merged 15 commits into from
Oct 31, 2023

Conversation

buckhalt
Copy link
Member

Adds error pages and error handling to all:

  • Data mutations
  • Complex components
  • Pages

Also creates default 404 pages.

@vercel
Copy link

vercel bot commented Oct 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fresco ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 2:34pm

@mrkarimoff mrkarimoff self-requested a review October 31, 2023 13:27
mrkarimoff
mrkarimoff suggested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@mrkarimoff mrkarimoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any major issues, but a small typo. This all looks like it's following the error handling rules in Next.js docs

@buckhalt buckhalt marked this pull request as ready for review October 31, 2023 14:56
@buckhalt buckhalt merged commit ee8402f into main Oct 31, 2023
3 checks passed
@jthrilly jthrilly deleted the feature/error-boundaries branch April 5, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkarimoff mrkarimoff mrkarimoff requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buckhalt @mrkarimoff @jthrilly