Fix Feedback Banner #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FeedbackBanner was rendering in the interview, even when there was
no logged in user. The components were also a mess.
This PR:
- Removes FeedbackBanner specific customization from the Banner
component.
- Creates a FeedbackBanner component in its own folder, which includes
the FeedbackButton, FeedbackModal, and SignOutModal components.
- Removes the FeedbackBanner from the interview view if there is no
logged in user.
- Alters the text of the banner and the sign out modal to be more
clear.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FeedbackBanner was rendering in the interview, even when there was
no logged in user. The components were also a mess.
This PR:
component.
the FeedbackButton, FeedbackModal, and SignOutModal components.
logged in user.
clear.