Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/drag drop #64

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Fix/drag drop #64

merged 5 commits into from
Feb 1, 2024

Conversation

buckhalt
Copy link
Member

Drag/drop system was broken when it was refactored for Fresco. This PR fixes drag/drop by reverting components to Interviewer versions. It also ensures that the MultiNodeBucket rerenders after a node is dropped into a categorical bin so that already-dropped nodes do not still appear in the list.

Fixes drag/drop on:

  • Name generator side panels
  • Ordinal bins
  • Categorical bins
  • Deleting a node

dragsource should be hidden while dragging. styles were not being applied due to typo
need rerender of transitiongroup after sortednodes changes. implemented using a key
Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fresco ✅ Ready (Inspect) Visit Preview Jan 31, 2024 10:49pm

@buckhalt buckhalt marked this pull request as ready for review January 31, 2024 22:50
Copy link
Member

@jthrilly jthrilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Like the solution with the component display name - I've never seen that before!

@jthrilly jthrilly merged commit a976ce3 into main Feb 1, 2024
5 checks passed
@jthrilly jthrilly deleted the fix/drag-drop branch March 28, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants