Feature/replace maxmind #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replacing maxmind in analytics microservice with simpler service that does not require api keys or account
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geo location provider
maxmindhas a complicated workflow to set up an account and get theirMAXMIND_ACCOUNT_IDandMAXMIND_LICENSE_KEY. Team decided to replacemaxmindwith IP-API inerror-analytics-microservicePR #18.The new implementation moves IP geolocation inside the analytics package so that there is no need for API keys, account, or
maxMindClientin Fresco.This PR removes
maxmindand references to it.Before merge:
@codaco/analyticsdependency version with released package once ready