Finish Interview Improvements #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds to appSettings, toggle setting on settings page
uses cookies-next to set a cookie with protocolId on complete interview. check for cookie in interview shell. if app setting limitInterviews and cookie is present, redirect to finished interview screen
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
allows us to use built in cookies from next/headers. also puts check/redirect in onboard route so that no interviews are created if condition is met.
mrkarimoff
reviewed
Feb 22, 2024
mrkarimoff
previously requested changes
Feb 22, 2024
jthrilly
reviewed
Feb 23, 2024
Comment on lines
+18
to
+25
| const appSettings = await api.appSettings.get.query(); | ||
|
|
||
| // if limitInterviews is enabled | ||
| // Check cookies for interview already completed for this user for this protocol | ||
| // and redirect to finished page | ||
| if (appSettings?.limitInterviews && cookies().get(protocolId)) { | ||
| redirect('/interview/finished'); | ||
| } |
There was a problem hiding this comment.
In future, think about making this a single function in a separate file, that the route handler and the page can both import. That way we can update the behaviour later in a simpler way.
jthrilly
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements several improvements to the Finish Interview functionality:
Confirm dialog UI/UX Improvements
Event tracking for InterviewCompleted
nodeCountandedgeCountmetadata addedOption to limit participants to one interview per protocol
limitInterviewssetting added toappSettings. Toggleable from app setup and settings page on the dashboardprotocolIdas the key. There are checks for the cookie in the/interviewand/onboardroutes. If cookie is present andlimitInterviewsis true, user is redirected to the thank you for participating page.