Make ViewController open #544
Conversation
|
This is work in progress. Before submitting for review, I would like to audit the whole |
tomaszpieczykolan
force-pushed
the
open_viewcontroller
branch
3 times, most recently
from
36588b9
to
90b3e9f
Compare
| func testTitleGetterAndSetter() { | ||
| let sut = ViewController() | ||
|
|
||
| // XCTAssertNil(sut.title) // This is currently failing, but the initial value of `title` should be `nil` |
There was a problem hiding this comment.
Oh interesting, this sounds like you've found a bug!
There was a problem hiding this comment.
Can this bug be fixed outside the scope of this PR, and can we mark this discussion as resolved?
There was a problem hiding this comment.
Yeah, that seems reasonable. Please write the test with the correct expectation; I'll add a utility to help mark the test as expected to fail.
tomaszpieczykolan
force-pushed
the
open_viewcontroller
branch
2 times, most recently
from
356c6f2
to
eaf7550
Compare
|
@tomaszpieczykolan would you mind rebasing the change? I think that the new features that I've enabled will be nice to take advantage of. |
tomaszpieczykolan
force-pushed
the
open_viewcontroller
branch
from
eaf7550
to
6b9c15d
Compare
Codecov Report
@@ Coverage Diff @@
## main #544 +/- ##
==========================================
+ Coverage 13.79% 14.98% +1.19%
==========================================
Files 111 111
Lines 4443 4443
==========================================
+ Hits 613 666 +53
+ Misses 3830 3777 -53
|
|
The ability to subclass |
|
I that that when the class is being marked |
This PR makes the
ViewControllerclassopen, so that it can be overriden.