-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adopt goyaml/v3 #153
adopt goyaml/v3 #153
Conversation
c241140
to
1d4cad2
Compare
What's current status of this? |
I didn't noticed the v3.0.0 release, this is something we should consider for next release, wdyt @glours @ulyssessouza ? |
One of the reasons to adopt v3 would be that v2 has a vulnerability https://nvd.nist.gov/vuln/detail/CVE-2019-11254 . |
Is there any blocker to get this merged? 🙏 |
updated with recent v3.0.1 release, still missing go-yaml/yaml#753 |
4488746
to
9a4f4c8
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Adopting go.yaml/v3 will bring support for yaml 1.2 schema
compatibility considerations:
project.MarshalYAML()
is configured to use only 2benefits:
!inline
as proposed on inline Dockerfile compose-spec#298