Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt goyaml/v3 #153

Merged
merged 1 commit into from
Mar 3, 2023
Merged

adopt goyaml/v3 #153

merged 1 commit into from
Mar 3, 2023

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Jul 1, 2021

Adopting go.yaml/v3 will bring support for yaml 1.2 schema

compatibility considerations:

  • go.yaml/v3 uses 4 spaces for indentation by default. project.MarshalYAML() is configured to use only 2
  • go.yaml/v3 force indentation on sequences (so the updated expected yaml in this PR). See Compact seq indent go-yaml/yaml#924

benefits:

@AkihiroSuda
Copy link
Contributor

What's current status of this?
I saw v3.0.0 was released recently.

@ndeloof
Copy link
Collaborator Author

ndeloof commented May 30, 2022

I didn't noticed the v3.0.0 release, this is something we should consider for next release, wdyt @glours @ulyssessouza ?

@AkihiroSuda
Copy link
Contributor

AkihiroSuda commented Jun 18, 2022

One of the reasons to adopt v3 would be that v2 has a vulnerability https://nvd.nist.gov/vuln/detail/CVE-2019-11254 .
Very unlikely to affect compose-go, but scanning tools are noisy about this CVE.

@AkihiroSuda
Copy link
Contributor

Is there any blocker to get this merged? 🙏

@ndeloof
Copy link
Collaborator Author

ndeloof commented Nov 15, 2022

updated with recent v3.0.1 release, still missing go-yaml/yaml#753

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof marked this pull request as ready for review March 2, 2023 10:03
@ndeloof ndeloof changed the title [WiP] adopt goyaml/v3 adopt goyaml/v3 Mar 2, 2023
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ndeloof ndeloof merged commit 5837d67 into compose-spec:master Mar 3, 2023
@milas milas mentioned this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants