New Multi Conflict Rule for transitive conflicts, to reduce memory use by rules #8424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative #8053 merged into 2.0 branch on the same sample: While the memory reduction on the latter seems close to this PR, the slowdown resulting from the new computation seems to be so significant that it's probably not worth exploring the dynamic nature of that change any further. |
|
Just to verify I reran the tests with the new 2.0 option COMPOSER_DISABLE_NETWORK=1 and the performance was hardly impacted, so definitely sticking with the solution in this PR. |
naderman
force-pushed
the
multi-conflict-rule
branch
from
3e89e8e
to
8ef9870
Compare
Implements the equals method correctly on multi conflict rules. If there are fewer literals a regular Rule2Literals is enough to represent the basic conflict rule.
naderman
force-pushed
the
multi-conflict-rule
branch
from
1b44f2e
to
28afc4d
Compare
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large part of rule memory is used up with rules representing transitive conflicts, or mutual exclusion. This PR implements a new type of rule representing a combination of all these individual rules into a single object, greatly reducing memory usage and consequently also improving performance.
This PR is an alternative approach to #8053 - the upside is that its approach is more generic than just different versions of one package name. At the same time the alternative approach in #8053 may reduce memory more effectively by getting rid of parts of the watch graph entirely. So will need to do some benchmarking and explore whether these two approaches can maybe even be combined.
Sylius example before (on 1.9 branch):
After (on 2.0 branch combined with this PR):