-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push rearchitecture to prod #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally rerender only Invite button rather than the whole sidebar
Notable differences: • Metadata API • Extracted Auth.js `SessionProvider` to new `AuthWrapper` client component • Extracted Sidebar conditional rendering to component-level Known issues: • It's bugging out about the styles • There was something with the `children` not being a valid React child or something like that
Notable differences: • Extracted sign in button to its own client component • Removed `next/head`, now taken care of by Metadata API • Returning a redirect object in `getServerSideProps` → `next/navigation` redirect Known issues: • Styles not working (todo switch from styled JSX) • Sidebar rendering "Loading..."
Conditionally rerender only Invite button rather than the whole sidebar
Will need to update dependents to call new server-side user management functions
Early experiments for #21
Instead, just return the invite info and logic handled as needed by caller
This lines up with reality: the amount of students that can have invites < the amount of USF students
See PR for more info
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10