PCHR-3654: Make it Impossible to Uncheck Work pattern As Default #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajesamson
reviewed
May 9, 2018
| $isToBeUncheckedAsDefault = isset($params['is_default']) && !$params['is_default']; | ||
| if($isToBeUncheckedAsDefault && $isDefaultWorkPattern) { | ||
| throw new CRM_HRLeaveAndAbsences_Exception_InvalidWorkPatternException( | ||
| 'It is not possible to have no default Work Pattern' |
There was a problem hiding this comment.
Does this also implies Default Work Pattern required.? Guess it will be more simplified if it means same thing.
There was a problem hiding this comment.
Yes a default Work pattern is required. A default work pattern is actually shipped with the default CiviHR installation
…ic methods. Add tests.
…efault PCHR-3660: Make it impossible to set a disabled Work pattern as default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, It is possible to unselect a work pattern as default, leaving a CiviHR site without a default work pattern which breaks many things. This PR fixes the issue and makes sure that the default work pattern can not be unselected to make it non default, rather default work pattern change should happen from edit/create screen of a new work pattern (This is the current behaviour).
Before
After
Note
This PR also contains changes from #2605 which is about making it impossible to set a disabled work pattern as default.