PCHR-3734: Update Task Badge when tasks are completed from SSP #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deb1990
changed the title
deb1990
force-pushed
the
PCHR-3734-refresh-tasks-notification-count
branch
from
15e24c3
to
909e4ac
Compare
AkA84
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the following problem
"Tasks count on menu does not get updated when Task is marked as complete"
Before
After
Technical Details
notification-badge.componentadded a listener to update the count when related data has changed from non-angular context(Wherepub-subis not not available.)document.addEventListener(vm.refreshCountEventName, fetchCount);The event is fired from https://github.com/compucorp/civihr-employee-portal/pull/469/files#diff-7d3b0cd4b2fd128befb8eb370c89d6acR195
Note: The event subscription code was written previously but I forgot to push the code for this repository but in the
civihr-employee-portalrepository the code was already merged.