Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
  • Loading branch information
compulim and corinagum authored Jul 23, 2019
1 parent 3e3ddf7 commit 5d41d33
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ assignees: ''
---

<!--
Thanks for posting the issue to us. Before posting, please remove any personal-identifiable information, secret, token, or conversation ID.
Thanks for posting the issue to us. Before posting, please remove any personally-identifiable information such as your secret, token, or conversation ID.
To expedite the fix, please follow this template and fill out as concise as possible.
To expedite the fix, please follow this template and fill out as concisely as possible.
-->

## Reproduce steps
Expand All @@ -28,9 +28,9 @@ But instead, it displayed the hero card with red background.

<!-- Please attach any screenshots with annotations, if any -->

## Versions
## Version

I tested on these versions of browsers:
I tested on the following browsers:

- [ ] Chrome: `latest`
- [ ] Edge: `latest`
Expand All @@ -39,7 +39,7 @@ I tested on these versions of browsers:

<!-- Please indicate if you host Web Chat under non-browser environment, e.g. Microsoft Teams, React Native, iOS WebView -->

I tested on these versions and variants of Web Chat:
I tested on the following versions and variants of Web Chat:

- [ ] Thru CDN, hosted by `https://cdn.botframework.com/`
- [ ] Thru NPM, React version of `16.x.x`
Expand All @@ -61,7 +61,7 @@ botframework-webchat:ui:version=

I think the background color of hero card should default to white color, and settable thru style options.

## Additional contexts
## Additional context

I am rendering an Adaptive Card and here is the content of the card.

Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ assignees: ''
<!--
To let use better understand your request, please follow this template and fill out as comprehensive as possible.
Creative ideas are not uncommon. Please check this query to see if anyone already on the same topic
Creative ideas are not uncommon. Please check the following to see if anyone has already requested the same feature:
https://github.com/microsoft/botframework-Webchat/issues?q=is%3Aissue+is%3Aopen+label%3ASample
-->
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/question.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ assignees: ''
---

<!--
🚨 We generally do not answer questions on GitHub. 🚨
🚨 We generally do not answer implementation questions on GitHub. 🚨
Please submit your question to https://stackoverflow.com/questions/tagged/botframework
Expand Down

0 comments on commit 5d41d33

Please sign in to comment.